perf: whole-file resolution for batch DELETE (A1 starter) - #372
Merged
Conversation
DeleteMultipleKeys now reads the whole plaintext legacy variable-length data file ONCE (guarded to <=32MB, non-encrypted, non-fixed-width) and decodes each target's PK/hash keys from that buffer via the B1 partial decoder, instead of issuing one pread pair per deleted row. Per-row engine.Read remains the fallback whenever the guard does not apply or a record is unexpectedly shaped. Measured (Release, comparative DELETE 10K of ~100K rows, median of 3): SQL ~42K -> ~53K ops/s, Direct ~57K -> ~69K ops/s (single run up to 81K).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat deze PR doet
A1-starter — whole-file resolutie voor batch DELETE (
fec15c31):DeleteMultipleKeysleest het plaintext legacy variabele-lengte.datéén keer (guard: ≤32 MB, niet-encrypted, niet fixed-width) en decodeert per target de PK/hash-sleutels uit dat geheugenbuffer via de B1-partiële decoder — i.p.v. één pread-paar per verwijderde rij. Per-rijengine.Readblijft de fallback (grote/encrypted/fixed-width bestanden, onverwachte recordvorm).Meting (Release, comparative DELETE 10K op ~100K rijen; median van 3)
Validatie
SharpCoreDB.Tests(Debug) + Release/CI-filter op alle vier de suites: EXIT=0.Bewuste vervolgstappen (nog open, zie docs/performance/EXECUTION_PLAN_UPDATE_DELETE.md)
Index.Delete+ maakt per-rij read overbodig; vereist PK-index-refresh-infra —Indexis nu een plain property zonder lazy rebuild).